Attributes cleanup in tests [12/20]#17096
Open
samueltardieu wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
hkBst
approved these changes
May 28, 2026
samueltardieu
force-pushed
the
attributes-cleanup-tests-12
branch
2 times, most recently
from
1a01808 to
5f08d77
Compare
samueltardieu
force-pushed
the
attributes-cleanup-tests-12
branch
2 times, most recently
from
8791e76 to
4d542ee
Compare
Merged
ada4a
requested changes
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Partial review due to a potential conflict with #17190 -- you could either perform the changes in this PR, or I could do in mine
| clippy::mem_replace_option_with_none, | ||
| clippy::mem_replace_with_default | ||
| clippy::mem_replace_with_default, | ||
| clippy::style |
Contributor
There was a problem hiding this comment.
it looks like clippy::style is a stand-in for clippy::mem_replace_option_with_some and clippy::mem_replace_with_uninit -- could you please change the file to use the latter instead?
Member
Author
There was a problem hiding this comment.
I've just removed the clippy::style which doesn't play a role here.
Comment on lines
+2
to
+4
| #
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
pull Bot
pushed a commit
to brightly-salty/rust-clippy
that referenced
this pull request
Jun 9, 2026
This ended up being bigger than I expected... This PR mainly does the following: - Commit 2 expands on rust-lang#17096 by cleaning up the attributes, and cleans up some more. - `mem_replace.rs` used to test `mem_replace_{option_with_none,option_with_some,default}`, which resulted in a rather big and messy file. Commits 4-6 split it into three. - Meanwhile, `mem_replace_with_uninit` was tested in a completely separate file, called `repl_uninit` (?!). Commit 3 renames it and cleans it up. As always, see the individual commits for more details. changelog: [`mem_replace_option_with_some`]: clean-up the lint message changelog: [`mem_replace_option_with_none`]: clean-up the lint message changelog: [`mem_replace_with_uninit`]: clean-up the lint message changelog: [`mem_replace_with_default`]: split off the suggestion from the main message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none
r? ada4a